RFR: JDK-8288699: cleanup HTML tree in HtmlDocletWriter.commentTagsToContent [v2]

Jonathan Gibbons jjg at openjdk.org
Thu Jul 7 22:22:43 UTC 2022


On Tue, 28 Jun 2022 16:04:30 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:

>> Jonathan Gibbons has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Add missing resource and example of use
>>    Fix Text and TextBuilder for Windows newlines
>>  - Merge remote-tracking branch 'upstream/master' into 8288699.commentTagsToContent
>>  - JDK-8288699: cleanup HTML tree in HtmlDocletWriter.commentTagsToContent
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java line 1558:
> 
>> 1556:                         }
>> 1557: 
>> 1558:                         if (dt instanceof TextTree tt){
> 
> Missing space before curly bracket.

fixed

> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java line 1561:
> 
>> 1559:                             String text = tt.getBody();
>> 1560:                             if (first && isHRef) {
>> 1561:                                 text = redirectRelativeLinks(element, (TextTree) dt);
> 
> Could use tt instead of casting again.

definitely; done

-------------

PR: https://git.openjdk.org/jdk/pull/9210


More information about the compiler-dev mailing list