RFR: 8268312: Compilation error with nested generic functional interface [v5]

[Vicente Romero]

On Mon, 11 Jul 2022 10:49:37 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   restoring the option for compressing diagnostics
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java line 4177:
> 
>> 4175: 
>> 4176:             Pair<Symbol, JCDiagnostic> c = errCandidate();
>> 4177:             if (compactMethodDiags) {
> 
> I believe the issue is here - the old code made the rewriting dependent on the value of `compactMethodDiags`, which in turns looked at which diagnostic formatter was installed. I think we should either move this check in `Log` (when we decide if we need to rewrite), or don't attach a rewriter if the `compactMethodDiags` is not set. I think it would be preferable to keep existing diagnostics as they are (and maybe cleanup the behavior of `compactMethodDiags` later, as an orthogonal fix).

yep I think this is the reason, will upload an updated iteration

-------------

PR: https://git.openjdk.org/jdk/pull/5586