[jdk19] RFR: 8290889: JDK 19 RDP2 L10n resource files update - msgdrop 10

Naoto Sato naoto at openjdk.org
Mon Jul 25 17:05:38 UTC 2022

On Sat, 23 Jul 2022 03:03:25 GMT, Alisen Chung <achung at openjdk.org> wrote:

> open l10n msg drop
> All tests passed.

Changes requested by naoto (Reviewer).

src/java.base/share/classes/sun/util/resources/CurrencyNames_de.properties line 63:

> 61: # written authorization of the copyright holder.
> 62: 
> 63: ADP=ADP

These currency symbols (`XXX=XXX`) are all in the base `CurrencyNames.properties`, so not needed in each localized resources (They are in the base in order to avoid throwing exceptions).

Also, the localized files should not reside in `java.base`, but to be merged with the ones in `jdk.localedata` module

These comments hold for all localized resources (de, ja, zh-CN). For furure reference, it may be good to add some comment in the base `CurrencyNames.properties` about this.

src/java.base/share/data/currency/CurrencyData_de.properties line 1:

> 1: #

`CurrencyData.properties` is not a localizable resource bundle, but a properties file containing currency data. No need to add these localized resources.


PR: https://git.openjdk.org/jdk19/pull/154

More information about the compiler-dev mailing list