RFR: JDK-8290901: Reduce use of -source in langtools tests [v5]
Jonathan Gibbons
jjg at openjdk.org
Fri Jul 29 17:29:56 UTC 2022
On Fri, 29 Jul 2022 17:24:51 GMT, Joe Darcy <darcy at openjdk.org> wrote:
>> To a first approximation, this change replaces use of "-source", where possible, with the preferable "--release" javac option. (There are cases where this swap is not desirable, such as when newer library features are being used in the test.)
>>
>> A few unneeded uses of -source were removed entirely.
>>
>> I'll update copyrights before any push.
>
> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix bug found in code review.
You probably don't need the `-Xlint:-options` in this case, because you are not checking the output with a reference output file, so the warning is mostly harmless.
I'll approve the review and leave it to you to decide whether to suppress the `-Xlint:-options`
Marked as reviewed by jjg (Reviewer).
-------------
PR: https://git.openjdk.org/jdk/pull/9622
More information about the compiler-dev
mailing list