RFR: 8288120: VerifyError with JEP 405 pattern match [v2]

Jan Lahoda jlahoda at openjdk.org
Wed Jun 22 13:17:58 UTC 2022


On Tue, 21 Jun 2022 14:50:50 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Using component's accessor, as suggested.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransPatterns.java line 359:
> 
>> 357:                                                   currentClass);
>> 358:             JCStatement accessorStatement =
>> 359:                     make.Return(make.App(make.Select(make.Ident(proxy.params().head), c.accessor)));
> 
> I let this to your consideration: it could be worth as part of this patch to check if there are other places in the record patterns code that can benefit from this simplification.

Thanks, but I don't recall other places in the current pattern matching code that would be looking up the accessors.

-------------

PR: https://git.openjdk.org/jdk19/pull/34


More information about the compiler-dev mailing list