RFR: 8257733: Move module-specific data from make to respective module [v11]

Magnus Ihse Bursie ihse at openjdk.java.net
Mon Mar 21 13:46:27 UTC 2022

> A lot (but not all) of the data in make/data is tied to a specific module. For instance, the publicsuffixlist is used by java.base, and fontconfig by java.desktop. (A few directories, like mainmanifest, is *actually* used by make for the whole build.) 
> These data files should move to the module they belong to. The are, after all, "source code" for that module that is "compiler" into resulting deliverables, for that module. (But the "source code" language is not Java or C, but typically a highly domain specific language or data format, and the "compilation" is, often, a specialized transformation.) 
> This misplacement of the data directory is most visible at code review time. When such data is changed, most of the time build-dev (or the new build label) is involved, even though this has nothing to do with the build. While this is annoying, a worse problem is if the actual team that needs to review the patch (i.e., the team owning the module) is missed in the review.
> ### Modules reviewed
> - [x] java.base
> - [x] java.desktop
> - [x] jdk.compiler
> - [x] java.se

Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 18 commits:

 - Merge tag 'jdk-19+14' into shuffle-data
   Added tag jdk-19+14 for changeset 08cadb47
 - Move x11wrappergen from share/data to unix/data
 - Fix fontconfig according to review request
 - Fix typos
 - Restore charsetmapping and cldr to make/data
 - Update copyright year
 - Merge branch 'master' into shuffle-data-reborn
 - Fix merge
 - Merge tag 'jdk-19+13' into shuffle-data-reborn
   Added tag jdk-19+13 for changeset 5df2a057
 - Move characterdata templates to share/classes/java/lang.
 - ... and 8 more: https://git.openjdk.java.net/jdk/compare/08cadb47...ea17b206


Changes: https://git.openjdk.java.net/jdk/pull/1611/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1611&range=10
  Stats: 140 lines in 619 files changed: 14 ins; 6 del; 120 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1611.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1611/head:pull/1611

PR: https://git.openjdk.java.net/jdk/pull/1611

More information about the compiler-dev mailing list