Integrated: 8257733: Move module-specific data from make to respective module

Magnus Ihse Bursie ihse at
Mon Mar 21 21:39:38 UTC 2022

On Thu, 3 Dec 2020 23:44:20 GMT, Magnus Ihse Bursie <ihse at> wrote:

> A lot (but not all) of the data in make/data is tied to a specific module. For instance, the publicsuffixlist is used by java.base, and fontconfig by java.desktop. (A few directories, like mainmanifest, is *actually* used by make for the whole build.) 
> These data files should move to the module they belong to. The are, after all, "source code" for that module that is "compiler" into resulting deliverables, for that module. (But the "source code" language is not Java or C, but typically a highly domain specific language or data format, and the "compilation" is, often, a specialized transformation.) 
> This misplacement of the data directory is most visible at code review time. When such data is changed, most of the time build-dev (or the new build label) is involved, even though this has nothing to do with the build. While this is annoying, a worse problem is if the actual team that needs to review the patch (i.e., the team owning the module) is missed in the review.
> ### Modules reviewed
> - [x] java.base
> - [x] java.desktop
> - [x] jdk.compiler
> - [x]

This pull request has now been integrated.

Changeset: f8878cb0
Author:    Magnus Ihse Bursie <ihse at>
Stats:     140 lines in 619 files changed: 14 ins; 6 del; 120 mod

8257733: Move module-specific data from make to respective module

Reviewed-by: jjg, weijun, naoto, erikj, prr, alanb, mchung



More information about the compiler-dev mailing list