RFR: JDK-8283661: Unexpected TypeElement in ANALYZE TaskEvent

Vicente Romero vromero at openjdk.java.net
Fri Mar 25 17:52:43 UTC 2022


On Fri, 25 Mar 2022 04:17:02 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a moderately simple set of changes to address issues found when using TaskListener to monitor the compilation of module-info and package-info files.
> 
> A new test is provided.
> 
> Full details and explanation in the JBS issue.

looks good, just nit suggestion

test/langtools/tools/javac/api/taskListeners/TestTypeElement.java line 72:

> 70:             @Override
> 71:             public void started(TaskEvent e) {
> 72:                 log.println("started: " + e);

you don't seem to be processing this output later on, I guess it could be removed, unless you want to keep it for debug reasons

-------------

Marked as reviewed by vromero (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7949


More information about the compiler-dev mailing list