RFR: JDK-8285869: Selective cleanup in doclint Checker class [v2]

[Jonathan Gibbons]

On Tue, 3 May 2022 22:16:25 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   address review feedback
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java line 866:
> 
>> 864:         if (paramElement == null) {
>> 865:             switch (env.currElement.getKind()) {
>> 866:                 case CLASS, INTERFACE -> {
> 
> A record can be generic too.

Yes, but RECORD is handled in a different case, along with METHOD and CONSTRUCTOR, because it can have "plain" `@param` as well as type-parameter `@param`.  In contrast, a class or interface can only have type-parameter `@param` and never plain `@param`.

> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java line 1230:
> 
>> 1228:         for (DocTree d: list) {
>> 1229:             switch (d.getKind()) {
>> 1230:                 case TEXT -> {
> 
> Using `switch` here seems overkill.

I almost fixed that one earlier. OK, I'll do that too. It was over-zealous use of use of unqualified names in an enum-switch

-------------

PR: https://git.openjdk.java.net/jdk/pull/8460