RFR: 8284220: TypeMirror#toString omits enclosing class names after JDK-8281238 [v6]
Joe Darcy
darcy at openjdk.java.net
Wed May 4 20:19:44 UTC 2022
On Wed, 4 May 2022 17:35:08 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:
>> Please consider this fix for https://bugs.openjdk.java.net/browse/JDK-8284220, which updates `ClassType#toString` to include enclosing class names when type annotations are present.
>>
>> For example, `java.util. at A Map.Entry<?,?>` is now printed as `java.util. at A Map.Entry<?,?>`, instead of `java.util. at A Entry<?,?>` (note the missing `Map`).
>
> Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>
> - Merge branch 'master' into JDK-8284220
> - Merge branch 'master' into JDK-8284220
> - Add more documentation to test
> - Merge branch 'openjdk:master' into JDK-8284220
> - Refactor test based on review feedback
> - 8284220: TypeMirror#toString omits enclosing class names after JDK-8281238
Looks fine.
-------------
Marked as reviewed by darcy (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8084
More information about the compiler-dev
mailing list