RFR: 8244681: Add a warning for possibly lossy conversion in compound assignments [v3]
Erik Gahlin
egahlin at openjdk.java.net
Wed May 11 13:08:49 UTC 2022
On Wed, 11 May 2022 12:59:49 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8244681: Add a warning for possibly lossy conversion in compound assignments
>> recommended correction of the warning description
>
> make/modules/jdk.jfr/Java.gmk line 26:
>
>> 24: #
>> 25:
>> 26: DISABLED_WARNINGS_java += exports lossy-conversions
>
> Note that with the fix of JDK-8286392 (and JDK-8286396) the `lossy-conversions` warning should not be disabled for the JFR code.
>
> In general, you need to check which of the subtasks of JDK-8286374 that has been fixed, and adjust the makefiles accordingly, before pushing this fix.
>
> (In the future, it might be easier to push the fix which disables the warnings first, and then file follow-up bugs on aa per-component basis, and remind them to remove the disabling in the makefile. That way there won't be a race between individual fixes and a "master" bug like this.)
I agree, but if it doesn't happen, I can follow up with a separate PR where I remove the disablement.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8599
More information about the compiler-dev
mailing list