RFR: 8244681: Add a warning for possibly lossy conversion in compound assignments [v10]
Adam Sotona
asotona at openjdk.java.net
Mon May 23 11:02:32 UTC 2022
> Please review this patch adding new lint option, **lossy-conversions**, to javac to warn about type casts in compound assignments with possible lossy conversions.
>
> The new lint warning is shown if the type of the right-hand operand of a compound assignment is not assignment compatible with the type of the variable.
>
> The implementation of the warning is based on similar check performed to emit "possible lossy conversion" compilation error for simple assignments.
>
> Proposed patch also include complex matrix-style test with positive and negative test cases of lossy conversions in compound assignments.
>
> Proposed patch also disables this new lint option in all affected JDK modules and libraries to allow smooth JDK build. Individual cases to address possibly lossy conversions warnings in JDK are already addressed in a separate umbrella issue and its sub-tasks.
>
> Thanks for your review,
> Adam
Adam Sotona has updated the pull request incrementally with two additional commits since the last revision:
- re-enabled lossy-conversion javac warnings in JDK Build Tools and jdk.compiler module
- Added man-page line about lossy-conversion lint
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8599/files
- new: https://git.openjdk.java.net/jdk/pull/8599/files/455720ef..4978c2a6
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8599&range=09
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8599&range=08-09
Stats: 5 lines in 3 files changed: 3 ins; 1 del; 1 mod
Patch: https://git.openjdk.java.net/jdk/pull/8599.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/8599/head:pull/8599
PR: https://git.openjdk.java.net/jdk/pull/8599
More information about the compiler-dev
mailing list