RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v11]

[Jim Laskey]

On Wed, 2 Nov 2022 20:07:15 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Internalize TemplateSupport
>
> src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java line 1103:
> 
>> 1101:         }
>> 1102: 
>> 1103:         MethodHandle mh = MethodHandles.dropArguments(newString(), 2, ttypes);
> 
> The code here us pretty dense. I suggest adding comments that show the type of `mh` as far as it is known. I think it makes it a much easier to keep track of what's going on (esp. what all the argument indexes mean). e.g.
> Suggestion:
> 
>         // (byte[],long,ttypes...) -> String
>         MethodHandle mh = MethodHandles.dropArguments(newString(), 2, ttypes);

Noted

-------------

PR: https://git.openjdk.org/jdk/pull/10889