RFR: JDK-8296287: Improve documentation for Types.directSupertypes()

Jan Lahoda jlahoda at openjdk.org
Fri Nov 4 09:08:31 UTC 2022


On Fri, 4 Nov 2022 05:46:28 GMT, Joe Darcy <darcy at openjdk.org> wrote:

> Please review the PR and CSR (https://bugs.openjdk.org/browse/JDK-8296354) to add text to explicitly specify the behavior of Types.directSupertypes on java.lang.Object.
> 
> (This text could be added as informative text as it is implied by the existing specification, but I think it was reasonable to add the text as a normative statement instead.)

Looks good to me.

test/langtools/tools/javac/processing/model/util/types/TestDirectSupertypeObject.java line 48:

> 46:         if (!roundEnv.processingOver()) {
> 47:             TypeMirror objectType  = requireNonNull(eltUtils.getTypeElement("java.lang.Object")).asType();
> 48:             var ojectSupertypes = typeUtils.directSupertypes(objectType);

Nit: `objectSupertypes` -> `objectSupertypes`.

-------------

Marked as reviewed by jlahoda (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10977


More information about the compiler-dev mailing list