RFR: JDK-8296287: Improve documentation for Types.directSupertypes()

Pavel Rappo prappo at openjdk.org
Fri Nov 4 11:21:04 UTC 2022

On Fri, 4 Nov 2022 05:46:28 GMT, Joe Darcy <darcy at openjdk.org> wrote:

> Please review the PR and CSR (https://bugs.openjdk.org/browse/JDK-8296354) to add text to explicitly specify the behavior of Types.directSupertypes on java.lang.Object.
> (This text could be added as informative text as it is implied by the existing specification, but I think it was reasonable to add the text as a normative statement instead.)

test/langtools/tools/javac/processing/model/util/types/TestDirectSupertypeObject.java line 27:

> 25:  * @test
> 26:  * @bug 8296287
> 27:  * @summary Test Types methods on module and package TypeMirrors

I don't think I understand the summary. Specifically, how are modules and packages pertinent to this test? (I'm not an expert in compiler area.)

test/langtools/tools/javac/processing/model/util/types/TestDirectSupertypeObject.java line 47:

> 45:                            RoundEnvironment roundEnv) {
> 46:         if (!roundEnv.processingOver()) {
> 47:             TypeMirror objectType  = requireNonNull(eltUtils.getTypeElement("java.lang.Object")).asType();

Redundant whitespace before =


PR: https://git.openjdk.org/jdk/pull/10977

More information about the compiler-dev mailing list