Integrated: 8294020: improve errors for record declarations

[Vicente Romero]

On Thu, 3 Nov 2022 02:39:07 GMT, Vicente Romero <vromero at openjdk.org> wrote:

> Although the reporter originally referred to the error message for records with no header, I think the issue is deeper. We intentionally didn't follow the same path for parsing record declarations as we do for, for example, classes. This is mainly because `class` is a keyword but `record` is a contextual keyword. So when we find `record` we are not sure if it is an identifier or a record declaration. Although I think that given a context where the compiler expects a type declaration, we can be more aggressive than before and if we find `record` + `identifier` consider it a record declaration. The current implementation of `JavacParser::isRecordStart` is trying to be too clever but it is actually leaving several cases uncovered. So the proposed simpler version should be more stable and make record related errors more similar to those for other class declarations. Test `RecordDeclarationSyntaxTest.java` has been added just to have a golden file that stores the error position.
> 
> TIA

This pull request has now been integrated.

Changeset: 60db5f2b
Author:    Vicente Romero <vromero at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/60db5f2ba271176292374b21c343cfc3167df562
Stats:     45 lines in 6 files changed: 15 ins; 13 del; 17 mod

8294020: improve errors for record declarations

Reviewed-by: jlahoda

-------------

PR: https://git.openjdk.org/jdk/pull/10963