RFR: 8294942: Compiler implementation for Record Patterns (Second Preview) [v4]

[Jan Lahoda]

On Wed, 9 Nov 2022 20:28:14 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Not looking for common supertype, not solving in a loop.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Infer.java line 709:
> 
>> 707: 
>> 708:         //step 1 - create fresh tvars
>> 709:         for (Type t : vars) {
> 
> I'm not sure about this so just a question: shouldn't we run this loop until no more undetVars need to be instantiated? we could also limit until a maximum number of steps in case we find cases that doesn't converge to a solution

In my understanding, we are not creating new undet vars here, and we instantiate them all in this loop, and fix their bounds if needed in the next step, so this should resolve all the vars.

-------------

PR: https://git.openjdk.org/jdk/pull/10814