RFR: 8296329: jar validator doesn't account for minor class file version [v2]

Bo Zhang duke at openjdk.org
Wed Nov 16 00:44:53 UTC 2022


On Tue, 15 Nov 2022 02:14:46 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Bo Zhang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   8296329: Only compare major versions in jar validator
>
> test/jdk/tools/jar/multiRelease/VersionValidatorTest.java line 116:
> 
> 
> My concern with this is that this will need to be updated after each release. Looks like there are also ways to directly alter the minor version of a class file, and I recommend doing that instead. See: https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/runtime/ClassFile/PreviewVersion.java#L51
> 
> Also, there's one more negative case missing where the base version uses 20 + preview features, and the other version is 19.

Thanks @JornVernee . I have updated the test, PTAL!

> Please assign the JBS ticket to yourself as well.

Sorry, I don't have permission to update JBS ticket.

-------------

PR: https://git.openjdk.org/jdk/pull/11153


More information about the compiler-dev mailing list