RFR: 8296329: jar validator doesn't account for minor class file version [v2]

Jorn Vernee jvernee at openjdk.org
Wed Nov 16 13:25:05 UTC 2022


On Wed, 16 Nov 2022 00:44:50 GMT, Bo Zhang <duke at openjdk.org> wrote:

>> As described in [JDK-8296329](https://bugs.openjdk.org/browse/JDK-8296329), previously, the jar validator compare the "version" to validate a multi-release jar. The "version" is a mix of the major and minor version fused into a single int, which might be a negative number with `--enable-preview` - this result in wrong comparison.
>> 
>> This PR fixes it by only comparing major versions.
>
> Bo Zhang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   8296329: Only compare major versions in jar validator

This looks good to me. Thanks for fixing.

I'm running a test job for tier 1-4 as well

Marked as reviewed by jvernee (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/11153


More information about the compiler-dev mailing list