RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v21]

Jim Laskey jlaskey at openjdk.org
Wed Nov 16 18:36:03 UTC 2022


On Wed, 16 Nov 2022 15:55:27 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Wrong line separator
>
> src/java.base/share/classes/java/util/FormatProcessor.java line 38:
> 
>> 36: 
>> 37: /**
>> 38:  * This {@linkplain ValidatingProcessor template processor} constructs a String
> 
> `String` is missing some javadoc wrapping

Changing.

> src/java.base/share/classes/java/util/FormatProcessor.java line 39:
> 
>> 37: /**
>> 38:  * This {@linkplain ValidatingProcessor template processor} constructs a String
>> 39:  * result using {@link Formatter}. Unlike {@link Formatter}, FormatProcessor uses the value from
> 
> And `FormatProcessor` too

Changing.

> src/java.base/share/classes/java/util/FormatProcessor.java line 51:
> 
>> 49:  * result is: <code>00010 + 00020 = 00030</code>
>> 50:  *
>> 51:  * @implNote When used in conjunction with a compiler generated {@link
> 
> Is this comment still relevant? E.g. the `When used in conjunction with compiler generated...` part. Doesn't javac always emit a call to the optimized linkage entry if it sees that the processor used is a ProcessorLinkage?

Changing.

-------------

PR: https://git.openjdk.org/jdk/pull/10889


More information about the compiler-dev mailing list