RFR: 8297444: Refactor the javacserver build tool [v2]

[Magnus Ihse Bursie]

On Tue, 22 Nov 2022 23:15:20 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> Things like incremental builds, some forced failure conditions etc?

I tested simple incremental builds but I should probably make a bit more advanced versions where I modify different files to trigger more real-life like scenarios, including compilation errors. Good point.

> make/langtools/tools/javacserver/client/Client.java line 148:
> 
>> 146:         cmd.addAll(Arrays.asList(conf.javaCommand().split(" ")));
>> 147:         // javacserver.server.Server is the server main class
>> 148:         cmd.add("javacserver.server.Server");
> 
> Did you consider referencing the class name using `Server.class.getName()`?

No, can't say I have. Do you think there is anything to gain by doing that? (Apart from possibly getting this right automatically if the class is renamed by IDE tools) (I'm not sure it would be a win in readability)

-------------

PR: https://git.openjdk.org/jdk/pull/11298