RFR: 8297444: Refactor the javacserver build tool [v2]

Andrey Turbanov aturbanov at openjdk.org
Thu Nov 24 20:22:12 UTC 2022


On Tue, 22 Nov 2022 23:40:30 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Now that the javacserver no longer has any ambitions outside being a buildtool customized for the JDK build process, a lot of abstractions and generalizations can be removed.
>> 
>> This will allow the actual behavior to be more clearly visible, and will help debugging the issues we are still seeing (most likely race conditions), and to convert the tool to use the ToolProvider API in the future.
>
> Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Fix typo #2
>    
>    Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
>  - Fix typo
>    
>    Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>

make/langtools/tools/javacserver/server/Server.java line 69:

> 67:     private static LazyInitFileLog errorLog;
> 68: 
> 69:     public static void main(String... args)  {

Nit:
Suggestion:

    public static void main(String... args) {

-------------

PR: https://git.openjdk.org/jdk/pull/11298


More information about the compiler-dev mailing list