RFR: JDK-8293877: Rewrite MineField test [v2]

Jonathan Gibbons jjg at openjdk.org
Mon Oct 3 17:12:39 UTC 2022


On Sun, 2 Oct 2022 04:08:20 GMT, Martin Buchholz <martin at openjdk.org> wrote:

> It's clear that javac team intends to have ToolProvider and command line invocation be very equivalent (good!) but I have memories of it being quite tricky to convert from one to the other, and I would be wary of lingering bugs, especially in the path handling code.
> 
> I care more than most about the performance of test runs, but for command line flags, I would always at least test them via subprocess invocation.

The comment is noted.   Generally, the javac code is _much_ better that it has been in times past, with better use of better abstractions. That being said, I agree there are different code paths in the outer layers of `javac` and it is important to be aware of the differences when introducing new options.

As for path options, I suspect any differences are more likely to arise when using the `JavaCompiler` (JSR199) API, compared to the `ToolProvider` and native launcher invocation.

-------------

PR: https://git.openjdk.org/jdk/pull/10366


More information about the compiler-dev mailing list