RFR: 8295176: some langtools test pollutes source tree
Srikanth Adayapalam
sadayapalam at openjdk.org
Mon Oct 17 10:24:56 UTC 2022
On Mon, 17 Oct 2022 09:35:40 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:
> The `ReleaseOptionThroughAPI.java` test compiles another test source, `ReleaseOption.java`. But it does not specify the output directory, so javac generates the classfile next to the source files into the source directory, causing trouble.
>
> The proposed fix is to add `-d .` to the test, so that the classfile is not generated into the working directory.
Marked as reviewed by sadayapalam (Reviewer).
I confirm that the proposed fix solves the problem.
I suggest a push either after
- cleaning up the Summary of ReleaseOption.java test OR
- deleting both the tests ReleaseOption.java and ReleaseOptionThroughAPI.java
Looks good to me.
-------------
PR: https://git.openjdk.org/jdk/pull/10724
More information about the compiler-dev
mailing list