RFR: 7039014: Confusing error message for method conflict [v2]
Archie L. Cobbs
duke at openjdk.org
Wed Oct 19 15:22:55 UTC 2022
On Wed, 19 Oct 2022 04:22:17 GMT, Vicente Romero <vromero at openjdk.org> wrote:
>> Archie L. Cobbs has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add a few more unit tests.
>
> test/langtools/tools/javac/Diagnostics/7039014/T7039014a.java line 5:
>
>> 3: * @bug 7039014
>> 4: * @summary Confusing error message for method conflict
>> 5: * @author archiecobbs
>
> nit: we don't add the `@author` tag anymore, it has been kept only if the original test had it, usually very old tests.
Thanks - removed.
> test/langtools/tools/javac/Diagnostics/7039014/T7039014a.java line 9:
>
>> 7: * @compile/fail/ref=T7039014a.out -XDrawDiagnostics T7039014a.java
>> 8: */
>> 9: public class T7039014a {
>
> I think that T7039014(a,b,c) should be combined into only one test
Good idea, thanks - done.
-------------
PR: https://git.openjdk.org/jdk/pull/10752
More information about the compiler-dev
mailing list