RFR: 8295729: Add jcheck whitespace checking for properties files [v3]
Weijun Wang
weijun at openjdk.org
Tue Oct 25 13:30:53 UTC 2022
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> Properties files is essentially source code. It should have the same whitespace checks as all other source code, so we don't get spurious trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increase the coverage of the whitespace checks (in the old mercurial version, this was more or less impossible).
>>
>> The only manual change is to `.jcheck/conf`. All other changes were made by running `find . -type f -iname "*.properties" | xargs gsed -i -e 's/[ \t]*$//'`.
>
> Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:
>
> - Revert "Remove check for .properties from jcheck"
>
> This reverts commit c91fdaa19dc06351598bd1c0614e1af3bfa08ae2.
> - Change trailing space and tab in values to unicode encoding
test/jdk/javax/net/ssl/Stapling/TEST.properties line 5:
> 3: java.base/sun.security.util \
> 4: java.base/sun.security.validator \
> 5: java.base/sun.security.x509\u0020
I'm quite sure this space can be safely removed.
-------------
PR: https://git.openjdk.org/jdk/pull/10792
More information about the compiler-dev
mailing list