RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v3]

Rémi Forax forax at openjdk.org
Fri Oct 28 19:55:07 UTC 2022


On Fri, 28 Oct 2022 19:34:37 GMT, Jim Laskey <jlaskey at openjdk.org> wrote:

>> src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java line 118:
>> 
>>> 116:      * @since 20
>>> 117:      */
>>> 118:     public static final int MAX_INDY_CONCAT_ARG_SLOTS = 200;
>> 
>> I do not think it's a good idea to make that constant available for everybody given that it's an artefact of the implementation.
>
> There have been several requests to make it public in the past.  You really can't use the methods in this class unless you know the value. Better to have the value exposed instead of developers transcribing the value into their code.

But it's an implementation details, BTW i wonder if the limitation is still valid, i know that John has changed the implementation of the BSM in that area.

-------------

PR: https://git.openjdk.org/jdk/pull/10889


More information about the compiler-dev mailing list