RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v3]

[Jim Laskey]

On Fri, 28 Oct 2022 19:06:43 GMT, Rémi Forax <forax at openjdk.org> wrote:

>> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update TemplateRuntime::combine
>
> src/java.base/share/classes/java/lang/template/StringTemplate.java line 175:
> 
>> 173:      * method {@code processor.process(this)}.
>> 174:      */
>> 175:     default <R, E extends Throwable> R process(ValidatingProcessor<R, E> processor) throws E {
> 
> signature should be `ValidatingProcessor<? extends R, ? extends E> processor`

Changing

> src/java.base/share/classes/java/lang/template/StringTemplate.java line 204:
> 
>> 202:      * embedded expressions fields, otherwise this method returns getters for the values list.
>> 203:      */
>> 204:     default public List<MethodHandle> valueGetters() {
> 
> I think i prefer the term accessors instead of getters

Changing

-------------

PR: https://git.openjdk.org/jdk/pull/10889