RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v3]

Jim Laskey jlaskey at openjdk.org
Mon Oct 31 14:49:30 UTC 2022


On Fri, 28 Oct 2022 19:36:07 GMT, Rémi Forax <forax at openjdk.org> wrote:

>> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update TemplateRuntime::combine
>
> src/java.base/share/classes/java/lang/template/TemplateRuntime.java line 325:
> 
>> 323:      * @throws NullPointerException fragments or values is null or if any of the fragments is null
>> 324:      */
>> 325:     static String interpolate(List<String> fragments, List<Object> values) {
> 
> I think it should be better to ensure that the caller always call with a List.of() or a List.copyOf() so null is not a possible element

Changing

-------------

PR: https://git.openjdk.org/jdk/pull/10889


More information about the compiler-dev mailing list