RFR: 8293116: Incremental JDK build could be sped up [v3]

[Jan Lahoda]

On Thu, 1 Sep 2022 16:48:48 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> Oh right, ListPathsSafely takes the data to write by reference, not by value (as in you supply the name of a variable that contains the data, not the data itself). I doubt `?` can be sent into an eval as a variable name, but I may be wrong. Perhaps you could extract the value into another variable first in a separate line in the recipe, something like this:
> 
> ```
>         $$(eval $1_MODFILES := $$?)
>         $$(eval $$(call ListPathsSafely, $1_MODFILES, $$($1_MODFILELIST)))
> ```
> 
> (note that I redefined $1_MODFILES to be the list of modified files and introduced a new variable $1_MODFILELIST for the filename where we print it)

Thanks! Done in:
https://github.com/openjdk/jdk/pull/10104/commits/23e3b75679908d26b76cc291a8efba06879c0d83

-------------

PR: https://git.openjdk.org/jdk/pull/10104