RFR: 8296420: javac has long lines in its command-line help [v2]

Archie L. Cobbs duke at openjdk.org
Tue Apr 4 17:54:18 UTC 2023


On Tue, 4 Apr 2023 17:32:20 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Archie L. Cobbs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Replace "whether or not" with just "whether".
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac.properties line 102:
> 
>> 100:     Options to pass to annotation processors
>> 101: javac.opt.implicit=\
>> 102:     Specify whether or not to generate class files\n\
> 
> There's been a lot of discussion (elsewhere) of late regarding the phrase _whether or not_.
> Generally, the consensus seems to be that the correct form in cases like this is just _whether_ and that _whether or not_ idiomatically means something else.   With that in mind, I'd suggest dropping _or not_ and then see how that affects the needs for any line-wrapping.

Nice - and now it fits in one line :)

Fixed in cfc2c3da3f1.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13329#discussion_r1157581102


More information about the compiler-dev mailing list