RFR: 8269957: facilitate alternate impls of NameTable and Name

Archie L. Cobbs duke at openjdk.org
Tue Apr 4 19:11:19 UTC 2023


On Mon, 3 Apr 2023 14:40:47 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Is it worth adding `StringNameTable` into the PR?

I was going to ask you the same question :) 

It's probably the right thing to do unless there's some rule against including code that's not normally going to be used.

We can add another secret flag to enable it. Currently we have `-XDuseUnsharedTable=true` which enables `UnsharedNameTable`, so we could add `-XDuseStringTable` to enable `StringNameTable`.

Added in 23bb34511cf.

> Is it worth putting static factory methods on `Name.Table` ?

Good idea.. but I think maybe they make more sense being added to `Names` rather than `Name.Table` since a `Names` object is a required parameter.

Added in c9cf3032819.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13282#issuecomment-1494544350


More information about the compiler-dev mailing list