RFR: JDK-8305620: Missing `break` in DocCommentParser `inlineWord()`

Iris Clark iris at openjdk.org
Wed Apr 5 02:44:05 UTC 2023


On Tue, 4 Apr 2023 23:58:28 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a fix for the `depth` counting in `DocCommentParser` `inlineWord`.
> There was a missing break that caused the count to go high, and because of that the code for the down count needed to be adjusted as well.
> 
> The test is modified to be stylistically more like the others with `abc` and `def` surrounding the `{@index...}` tag.  This looks like it may have been a typo, and helped hide the counting issue.

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/13343#pullrequestreview-1372061788


More information about the compiler-dev mailing list