RFR: JDK-8305591: Cleanup use of `newline` flag in DocCommentParser [v2]

Jonathan Gibbons jjg at openjdk.org
Wed Apr 5 15:39:19 UTC 2023

On Wed, 5 Apr 2023 11:41:35 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:

>> Jonathan Gibbons has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>>  - Remove redundant @SuppressWarnings
>>  - Merge remote-tracking branch 'upstream/master' into 8305591.dcp-newline
>>  - JDK-8305591: Cleanup use of `newline` flag in DocCommentParser
> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/DocCommentParser.java line 568:
>> 566:             switch (ch) {
>> 567:                 case '\n':
>> 568:                 case '\r': case '\f': case ' ': case '\t':
> This is not a big issue, but it seems that with #13343 adding the break to the `case '@'` below, the `@SuppressWarnings("fallthrough")` could now be removed from this method, right?

The extra `@SuppressWarnings` has been removed.


PR Review Comment: https://git.openjdk.org/jdk/pull/13341#discussion_r1158689220

More information about the compiler-dev mailing list