RFR: JDK-8042981: Strip type annotations in Types' utility methods [v2]

Vicente Romero vromero at openjdk.org
Thu Apr 6 23:35:52 UTC 2023

On Sun, 26 Jun 2022 22:52:43 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Early review for JDK-8042981: "Strip type annotations in Types' utility methods". I work more often in the Element world rather than the Type word of the annotation processing APIs.
>> The type annotations on primitive types are *not* cleared by the existing annotation clearing mechanisms. I suspect Type.Visitor is missing a case for primitive types. Someone with familiarity with javac's type modeling should take a look; thanks.
> Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>  - Update visitor; all langtools regression tests pass.
>  - Merge branch 'master' into JDK-8042981
>  - JDK-8042981: Strip type annotations in Types' utility methods

test/langtools/tools/javac/processing/model/util/types/TestAnnotationStripping.java line 70:

> 68:                 checkExpectedTypeAnnotations(returnType, expectedAnnotation);
> 69: 
> 70: //                 System.err.print("\tasElement()");

should this debugging? code be kept?

test/langtools/tools/javac/processing/model/util/types/TestAnnotationStripping.java line 79:

> 77:                 checkEmptyAnnotations(typeUtils.erasure(returnType));
> 78: 
> 79: //                 System.err.print("\tgetArrayType()");

same comment as above


PR Review Comment: https://git.openjdk.org/jdk/pull/8984#discussion_r1160333452
PR Review Comment: https://git.openjdk.org/jdk/pull/8984#discussion_r1160333536

More information about the compiler-dev mailing list