RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v57]

[Andrey Turbanov]

On Wed, 12 Apr 2023 19:02:22 GMT, Jim Laskey <jlaskey at openjdk.org> wrote:

>> Enhance the Java programming language with string templates, which are similar to string literals but contain embedded expressions. A string template is interpreted at run time by replacing each expression with the result of evaluating that expression, possibly after further validation and transformation. This is a [preview language feature and API](http://openjdk.java.net/jeps/12).
>
> Jim Laskey has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 75 commits:
> 
>  - Merge branch 'master' into 8285932
>  - Change MAX_INDY_CONCAT_ARG_SLOTS to be updatable.
>  - Clean up Error handling
>  - Recommended changes
>  - RuntimeException is the only exception type that can is deduced from a lambda.
>  - Update combine example
>  - Merge branch 'master' into 8285932
>  - Update StringTemplate.combine javadoc
>  - Requested review changes.
>  - Clean up list construction
>  - ... and 65 more: https://git.openjdk.org/jdk/compare/bc151633...f1b187a1

src/java.base/share/classes/java/lang/runtime/Carriers.java line 286:

> 284:          */
> 285:         MethodHandle constructor(CarrierShape carrierShape) {
> 286:             int longCount = carrierShape.longCount();

`longCount`/`intCount` seems unused in this method

src/java.base/share/classes/java/lang/runtime/Carriers.java line 369:

> 367:          * Cache mapping {@link MethodType} to previously defined {@link CarrierElements}.
> 368:          */
> 369:         private static Map<MethodType, CarrierElements>

Can it be made `final` ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/10889#discussion_r1164641033
PR Review Comment: https://git.openjdk.org/jdk/pull/10889#discussion_r1164640633