RFR: 8305955: Remove Visual C++ specific workaround in javac
Jan Lahoda
jlahoda at openjdk.org
Thu Apr 13 12:02:11 UTC 2023
On Thu, 13 Apr 2023 11:36:15 GMT, Julian Waters <jwaters at openjdk.org> wrote:
> Visual C++ no longer requires the use of the i64 literal syntax and instead recommends the use of LL instead, so we should remove this workaround in the JNIWriter (this also helps when users write Windows JNI code meant to be compiled with alternate compilers other than Visual C++)
I think I'd like to understand more about "Visual C++ no longer requires" - since when, how (un-)realistic is it that people would still be using a C++ compiler that would require the workaround, etc.
Because, as far as I know, the `JNIWriter` is used by users to generate the headers, and those users may be using various compilers, so I think we should verify we won't break the users.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13457#issuecomment-1506841794
More information about the compiler-dev
mailing list