RFR: 8305672: Surprising definite assignment error after JDK-8043179

[Liam Miller-Cushon]

On Wed, 5 Apr 2023 22:42:58 GMT, Archie L. Cobbs <duke at openjdk.org> wrote:

> The fix for [JDK-8043179](https://bugs.openjdk.org/browse/JDK-8043179) is to clear the DU flags for all variables when entering a lamba. This reflects the fact that the lamba's actual execution could be arbitrarily far in the future, so we can't assume anything that is DU when the lambda is created is still DU when the lambda actually executes.
> 
> However, this fix created a new bug. The problem is that `visitLambda()` does not save & restore the `uninitsTry` bits, which are used by `visitTry()` to track DU variables within `try { }` blocks. So if there is a `try { }` block outside the lambda and a `try { }` block inside the lambda, the latter can "leak" DU state up to the former via this field. As a result, a final variable that should still be DU at the completion of the outer `try { }` block can be incorrectly recorded as not DU, leading to the bogus "might already have been assigned" error.
> 
> This patch fixes that by adding the necessary save & restore logic.

I'm not a Reviewer, but this looks good to me. I confirmed this fixes the original issue that I minimized for JDK-8305672.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13366#issuecomment-1507628442