RFR: 8300543 Compiler Implementation for Pattern Matching for switch [v2]

Maurizio Cimadamore mcimadamore at openjdk.org
Tue Apr 18 14:37:56 UTC 2023


On Tue, 18 Apr 2023 14:31:30 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jan Lahoda has updated the pull request incrementally with six additional commits since the last revision:
>> 
>>  - Fixing infinite loop where a binding pattern is replaced with a binding pattern for the same type.
>>  - Reflecting review comments.
>>  - Fixing exhaustiveness for unsealed supertype pattern.
>>  - No need to enable features after error reported.
>>  - SwitchBootstraps.typeSwitch should not initialize enum classes.
>>  - A prototype of avoiding enum initialization.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java line 1021:
> 
>> 1019:              *    on patterns in the chosen column, as described above
>> 1020:              */
>> 1021:             var grouppedPerRecordClass =
> 
> Suggestion:
> 
>             var groupedPerRecordClass =

or `patternsByRecordClass`, or `groupByRecordClass` (the latter would be consistent with `groupByHash` which is used below)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13074#discussion_r1170131872


More information about the compiler-dev mailing list