RFR: JDK-8304036: Use CommandLine class from shared module [v2]

Jonathan Gibbons jjg at openjdk.org
Fri Apr 21 21:42:47 UTC 2023

On Fri, 21 Apr 2023 21:14:00 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> This pull request addresses the open ends left by [JDK-8236919](https://bugs.openjdk.org/browse/JDK-8236919):
>> - #11272
>> Changes:
>> - [x] Extend list of targeted exports of `jdk.internal.opt/jdk.internal.opt` to `jdk.compiler` and `jdk.javadoc`
>> - [x] Use shared `CommandLine.java` in `jdk.compiler` module
>> - [x] Use shared `CommandLine.java` in `jdk.javadoc` module
>> - [x] Remove `CommandLine.java` from `jdk.compiler` module
> Christian Stein has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>  - Merge branch 'openjdk:master' into JDK-8304036-reusable-command-line-part-2
>  - Add missing import
>  - JDK-8304036: Use CommandLine class from shared module

Marked as reviewed by jjg (Reviewer).


PR Review: https://git.openjdk.org/jdk/pull/12997#pullrequestreview-1396422793

More information about the compiler-dev mailing list