RFR: 8302344: Compiler Implementation for Unnamed patterns and variables (Preview) [v4]

[Joe Darcy]

On Thu, 27 Apr 2023 14:56:53 GMT, Aggelos Biboudis <abimpoudis at openjdk.org> wrote:

>> This PR implements [JEP 443](https://openjdk.org/jeps/443), the preview feature for Unnamed Patterns and Variables in Java.
>> 
>> Draft Spec: https://cr.openjdk.org/~abimpoudis/unnamed/latest/
>
> Aggelos Biboudis has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update test files with JDK 8307007 bug id

src/java.compiler/share/classes/javax/lang/model/element/VariableElement.java line 106:

> 104:      * false} otherwise}
> 105:      *
> 106:      * @jls 6.1 Declarations

Please include an implSpec tag for returning false by default.

src/java.compiler/share/classes/javax/lang/model/util/Elements.java line 714:

> 712:     /**
> 713:      * {@return {@code true} if the element has an empty name, {@code false} otherwise}
> 714:      *

Please include an implSpec tag for returning false by default.

For testing the default method, see the use of VaccuousElements in tests in files like

test/langtools/tools/javac/processing/model/util/elements/TestRecordPredicates.java

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13528#discussion_r1179474266
PR Review Comment: https://git.openjdk.org/jdk/pull/13528#discussion_r1179481934