RFR: 8292275: javac does not emit SYNTHETIC and MANDATED flags for parameters by default [v7]

[Vicente Romero]

On Thu, 27 Apr 2023 20:10:56 GMT, Chen Liang <liach at openjdk.org> wrote:

>> make/langtools/src/classes/build/tools/symbolgenerator/CreateSymbols.java line 2388:
>> 
>>> 2386:                 for (MethodParameters_attribute.Entry e : params.method_parameter_table) {
>>> 2387:                     String name = null;
>>> 2388:                     if (e.name_index != 0) {
>> 
>> could use ternary operator here, but tbh not sure why this change is necessary. The current code is supposed to fail with `ConstantPool.InvalidIndex` exception if the an index is `<= 0`, is this changing now? I mean can `name_index` be `0` now?
>
> `name_index` could always have been 0 to indicate an absent parameter name: https://docs.oracle.com/javase/specs/jvms/se20/html/jvms-4.html#jvms-4.7.24

I see, then this was a bug in the previous code, still I suggest using the ternary operator here

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/9862#discussion_r1179872355