RFR: 8305672: Surprising definite assignment error after JDK-8043179 [v3]

Neal Gafter duke at openjdk.org
Sun Apr 30 18:16:22 UTC 2023

On Wed, 26 Apr 2023 02:59:53 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

>> The fix for [JDK-8043179](https://bugs.openjdk.org/browse/JDK-8043179) is to clear the DU flags for all variables when entering a lamba. This reflects the fact that the lamba's actual execution could be arbitrarily far in the future, so we can't assume anything that is DU when the lambda is created is still DU when the lambda actually executes.
>> However, this fix created a new bug. The problem is that `visitLambda()` does not save & restore the `uninitsTry` bits, which are used by `visitTry()` to track DU variables within `try { }` blocks. So if there is a `try { }` block outside the lambda and a `try { }` block inside the lambda, the latter can "leak" DU state up to the former via this field. As a result, a final variable that should still be DU at the completion of the outer `try { }` block can be incorrectly recorded as not DU, leading to the bogus "might already have been assigned" error.
>> This patch fixes that by adding the necessary save & restore logic.
> Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>  - Merge branch 'master' into JDK-8305672
>  - Merge branch 'master' into JDK-8305672
>  - Fix failure of visitLambda() to save & restore uninitsTry bits.

Looks good to me.


Marked as reviewed by gafter at github.com (no known OpenJDK username).

PR Review: https://git.openjdk.org/jdk/pull/13366#pullrequestreview-1406622608

More information about the compiler-dev mailing list