RFR: 8295058: test/langtools/tools/javac 116 tests classes use com.sun.tools.classfile library [v2]

[Qing Xiao]

On Tue, 1 Aug 2023 13:28:49 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> Qing Xiao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Modified 3 files according to reviews
>
> test/langtools/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest3.java line 571:
> 
>> 569:     }
>> 570: 
>> 571:     /************ Helper annotations counting methods ******************/
> 
> Arn't these test methods duplicated in the ClassfileTestHelper?

Modified in the latest commit. I keep extending the ClassfileTestHelper, and only migrate the Test methods.

> test/langtools/tools/javac/annotations/typeAnnotations/classfile/Scopes.java line 65:
> 
>> 63:     @Target({ElementType.TYPE_USE})
>> 64:     @interface UniqueInner { };
>> 65: }
> 
> missing new line

Modified in the latest commit

> test/langtools/tools/javac/classfiles/attributes/Signature/EnumTest.java line 1:
> 
>> 1: /*
> 
> This is probably a mistake, I see content of EnumTest replaced with Driver class.

Modified in the latest commit

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14874#discussion_r1280787466
PR Review Comment: https://git.openjdk.org/jdk/pull/14874#discussion_r1280785773
PR Review Comment: https://git.openjdk.org/jdk/pull/14874#discussion_r1280785593