RFR: 8313693: Introduce an internal utility for the Damerau–Levenshtein distance calculation [v2]
Pavel Rappo
prappo at openjdk.org
Fri Aug 4 18:36:33 UTC 2023
On Fri, 4 Aug 2023 17:19:40 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Feedback
>
> test/langtools/tools/javac/util/StringUtilsTest.java line 125:
>
>> 123: void assertTrue(boolean cond) {
>> 124: if (!cond) {
>> 125: throw new IllegalStateException();
>
> Mildly surprising to see `IllegalStateException` in `assert...` methods.
I simply followed the style of the file.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15157#discussion_r1284730704
More information about the compiler-dev
mailing list