RFR: JDK-8307184: Incorrect/inconsistent specification and implementation for Elements.getDocComment [v10]

[Jonathan Gibbons]

On Wed, 9 Aug 2023 20:25:28 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Start by just reformatting the existing specs to highlight subsequent spec changes.
>
> Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
> 
>  - Implement review feedback.
>  - Merge branch 'master' into JDK-8307184
>  - Add test case for newlines.
>  - Use "whitespace" as an adjective.
>  - Augment test.
>  - Respond to review comments.
>  - Merge branch 'master' into JDK-8307184
>  - Appease jcheck.
>  - Updates.
>  - Add tests; adjust spec.
>  - ... and 2 more: https://git.openjdk.org/jdk/compare/c3976970...9e5c7b04

Marked as reviewed by jjg (Reviewer).

test/langtools/tools/javac/processing/model/util/elements/TestGetDocComments.java line 60:

> 58:                         if (!expectedCommentStr.equals(actualComment)) {
> 59:                             messager.printError("Unexpected doc comment found", element);
> 60:                             (new ToolBox()).checkEqual(expectedCommentStr.lines().toList(),

:-)

-------------

PR Review: https://git.openjdk.org/jdk/pull/15062#pullrequestreview-1570489413
PR Review Comment: https://git.openjdk.org/jdk/pull/15062#discussion_r1289153401