RFR: 8269957: facilitate alternate impls of NameTable and Name [v4]

[Archie Cobbs]

On Fri, 25 Aug 2023 22:30:34 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
>> 
>>  - Merge branch 'master' into JDK-8269957
>>  - Merge branch 'master' into JDK-8269957
>>  - Merge branch 'master' into JDK-8269957
>>  - Merge branch 'master' into JDK-8269957
>>  - Move equals() table check into common superclass.
>>  - Add Name.Table factory methods to Names class.
>>  - Add StringNameTable as a new (optional) Name.Table implementation.
>>  - Add a few more default method implementations to Name superclass.
>>  - Revert some unnecessary changes.
>>  - Merge branch 'master' into JDK-8269957
>>  - ... and 1 more: https://git.openjdk.org/jdk/compare/f2399546...e386ea3e
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/util/StringNameTable.java line 51:
> 
>> 49: 
>> 50:     public StringNameTable(Names names) {
>> 51:         this(names, 8000);
> 
> did you mean: 0x8000?

Yes, thanks... was trying to cut & paste from `SharedNameTable()` but dropped the `0x` somehow. Fixed in 3c6d9145219.

> src/jdk.compiler/share/classes/com/sun/tools/javac/util/Utf8NameTable.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 1999, 2021, Oracle and/or its affiliates. All rights reserved.
> 
> nit: copyright year should only be 2023

Thanks, fixed in 193d06662dd.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13282#discussion_r1306202448
PR Review Comment: https://git.openjdk.org/jdk/pull/13282#discussion_r1306202921