RFR: JDK-8315248: AssertionError in Name.compareTo

Vicente Romero vromero at openjdk.org
Wed Aug 30 02:15:13 UTC 2023

On Wed, 30 Aug 2023 00:25:52 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a small fix to avoid an `AssertionError` coming out of `CharSequence.compare` for two `CharSequence` objects obtained from different instances of the `javax.lang.model` API.
> Full details in the JBS issue and comments.
> There are some minor cleanup edits as well, and some improvements to the code to throw AssertionError in a few places.

looks good

test/langtools/tools/javac/nametable/TestNameTables.java line 87:

> 85: 
> 86:     /**
> 87:      * Tests operations using a single name tbale

typo: tbale


Marked as reviewed by vromero (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15478#pullrequestreview-1601755951
PR Review Comment: https://git.openjdk.org/jdk/pull/15478#discussion_r1309536739

More information about the compiler-dev mailing list