RFR: JDK-8315248: AssertionError in Name.compareTo [v2]

Vicente Romero vromero at openjdk.org
Wed Aug 30 17:59:26 UTC 2023

On Wed, 30 Aug 2023 17:52:55 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Please review a small fix to avoid an `AssertionError` coming out of `CharSequence.compare` for two `CharSequence` objects obtained from different instances of the `javax.lang.model` API.
>> Full details in the JBS issue and comments.
>> There are some minor cleanup edits as well, and some improvements to the code to throw AssertionError in a few places.
> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>   Address review feedback

last changes look good to me


Marked as reviewed by vromero (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15478#pullrequestreview-1603231052

More information about the compiler-dev mailing list