RFR: 8314632: Intra-case dominance check fails in the presence of a guard

Jan Lahoda jlahoda at openjdk.org
Thu Aug 31 16:07:03 UTC 2023

On Thu, 31 Aug 2023 12:33:26 GMT, Aggelos Biboudis <abimpoudis at openjdk.org> wrote:

> Intra-case domination should be affected by the presence of a guard. A missing check in dominance ensures that requirement.

Overall, looks good to me, but please see the inline comment. Thanks!

test/langtools/tools/javac/patterns/T8314632.java line 23:

> 21:  * questions.
> 22:  */
> 23: /*

For tests with golden files, we typically don't use a license header, and use `/nodynamiccopyright/` after `@test`. This is because the line numbers are important, and the test would fail if the license header would change.


Changes requested by jlahoda (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15515#pullrequestreview-1605123935
PR Review Comment: https://git.openjdk.org/jdk/pull/15515#discussion_r1311863936

More information about the compiler-dev mailing list